From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Git List <git@vger.kernel.org>, John Keeping <john@keeping.me.uk>,
Sverre Rabbelier <srabbelier@gmail.com>, Max Horn <max@quendi.de>,
Jonathan Nieder <jrnieder@gmail.com>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH v2 3/6] transport-helper: clarify pushing without refspecs
Date: Thu, 18 Apr 2013 20:41:17 -0700 [thread overview]
Message-ID: <7v4nf34276.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAPig+cRp7J+HYBA=2OL-CdA3NiQFjuUMZEjE+i+SnNrrPBAZ6Q@mail.gmail.com> (Eric Sunshine's message of "Thu, 18 Apr 2013 20:27:45 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> + grep "remote-helper doesn.t support push; refspec needed" error
>
> Is "doesn.t" intentional? It certainly works by accident in grep, but
> did you mean s/doesn.t/doesn't/ ?
The pattern matching the expected string is not by accident, but by
design.
It of course can be made more strict to reject "doesnot" and require
"doesn't" by doing something like this:
grep "remote-helper doesn'\''t support push; refspec needed" error
but at some point, it simply stops being worth it to tighten the
pattern.
For that matter, it could be as loose as
grep "support push; refspec needed" error
if you know the string is unique enough.
next prev parent reply other threads:[~2013-04-19 3:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 4:14 [PATCH v2 0/6] transport-helper: some clarifications and a fix Felipe Contreras
2013-04-18 4:14 ` [PATCH v2 1/6] transport-helper: clarify *:* refspec Felipe Contreras
2013-04-18 8:24 ` John Keeping
2013-04-18 9:27 ` Felipe Contreras
2013-04-18 9:45 ` John Keeping
2013-04-18 10:02 ` Felipe Contreras
2013-04-18 10:06 ` John Keeping
2013-04-18 17:27 ` Junio C Hamano
2013-04-18 19:07 ` Felipe Contreras
2013-04-18 4:14 ` [PATCH v2 2/6] transport-helper: update refspec documentation Felipe Contreras
2013-04-18 4:14 ` [PATCH v2 3/6] transport-helper: clarify pushing without refspecs Felipe Contreras
2013-04-18 10:11 ` John Keeping
2013-04-18 10:14 ` Felipe Contreras
2013-04-18 10:24 ` John Keeping
2013-04-18 17:29 ` Junio C Hamano
2013-04-18 18:35 ` John Keeping
2013-04-18 17:28 ` Junio C Hamano
2013-04-19 0:27 ` Eric Sunshine
2013-04-19 0:30 ` Felipe Contreras
2013-04-19 3:41 ` Junio C Hamano [this message]
2013-04-18 4:14 ` [PATCH v2 4/6] transport-helper: warn when refspec is not used Felipe Contreras
2013-04-18 17:30 ` Junio C Hamano
2013-04-18 19:12 ` Felipe Contreras
2013-04-18 4:14 ` [PATCH v2 5/6] transport-helper: trivial code shuffle Felipe Contreras
2013-04-18 4:14 ` [PATCH v2 6/6] transport-helper: update remote helper namespace Felipe Contreras
2013-04-18 17:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4nf34276.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
--cc=max@quendi.de \
--cc=srabbelier@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).