From: Junio C Hamano <gitster@pobox.com>
To: Ivan Todoroski <grnch@gmx.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option
Date: Mon, 02 Apr 2012 12:34:56 -0700 [thread overview]
Message-ID: <7v4nt2exlr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 4F79C2C8.3020009@gmx.net
Ivan Todoroski <grnch@gmx.net> writes:
> +test_expect_success 'setup tests for the --stdin parameter' '
> + for head in C D E F
> + do
> + add $head
> + done &&
> + for head in A B C D E F
> + do
> + git tag $head $head
> + done
> + cat >input <<EOF
> +refs/heads/C
> +refs/heads/A
> +refs/heads/D
> +refs/tags/C
> +refs/heads/B
> +refs/tags/A
> +refs/heads/E
> +refs/tags/B
> +refs/tags/E
> +refs/tags/D
> +EOF
> + sort <input >expect
> + (
> + echo refs/heads/E &&
> + echo refs/tags/E &&
> + cat input
> + ) >input.dup
> +'
This breaks && chain; also it is easier to read if indentation is used
properly.
I'll queue it after fixing the above locally (the rest looked OK to me).
Thanks.
next prev parent reply other threads:[~2012-04-02 19:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 15:11 [PATCH v3 0/4] Clone fails on a repo with too many heads/tags Ivan Todoroski
2012-04-02 15:13 ` [PATCH v3 1/4] fetch-pack: new --stdin option to read refs from stdin Ivan Todoroski
2012-04-02 20:42 ` Jeff King
2012-04-02 15:14 ` [PATCH v3 2/4] remote-curl: send the refs to fetch-pack on stdin Ivan Todoroski
2012-04-02 18:50 ` Junio C Hamano
2012-04-02 15:16 ` [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option Ivan Todoroski
2012-04-02 19:34 ` Junio C Hamano [this message]
2012-04-03 0:23 ` Ivan Todoroski
2012-04-02 15:17 ` [PATCH v3 4/4] remote-curl: main test case for the OS command line overflow Ivan Todoroski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4nt2exlr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=grnch@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).