From: Junio C Hamano <gitster@pobox.com>
To: Rodrigo Silva "\(MestreLion\)" <linux@rodrigosilva.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: improve description of GIT_EDITOR and preference order
Date: Mon, 26 Mar 2012 11:31:58 -0700 [thread overview]
Message-ID: <7v4ntbp61t.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: loom.20120326T100258-967@post.gmane.org
Rodrigo Silva "(MestreLion)" <linux@rodrigosilva.com> writes:
> So, what should I do now? Re-send the patch with just the accepted parts
> (and adjusting commit message accordingly)? Or this will be done by you?
People either say "Yeah, I agree with the suggestions---can you apply it
without the change to git-var.txt?", or respond to the review message with
an updated patch with "I agree with the review suggestion and dropped the
change to git-var.txt" after the three-dash lines (i.e. the comment does
not become part of the commit log message).
For something small and easy like this one, it's OK to do either way.
For larger changes, people tend to do the latter, as often they do not
agree (and they do not have to) with *all* the point raised in the review,
and it would become more error prone to let me pick, choose and edit the
original submission.
I'll just apply your patch with minor tweaks. Thanks.
prev parent reply other threads:[~2012-03-26 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:38 [PATCH] Documentation: improve description of GIT_EDITOR and preference order Rodrigo Silva (MestreLion)
2012-03-23 18:18 ` Junio C Hamano
2012-03-26 8:11 ` Rodrigo Silva (MestreLion)
2012-03-26 18:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4ntbp61t.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=linux@rodrigosilva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).