git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, Tony Wang <wwwjfy@gmail.com>
Subject: Re: [PATCH 1/3] Convert resolve_ref+xstrdup to new resolve_refdup function
Date: Mon, 12 Dec 2011 00:13:09 -0800	[thread overview]
Message-ID: <7v4nx68ay2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8C0CJyHdtWJ5QVqX9ksHWgdBpm6XekQ+mZP4sxBVA_8vQ@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Sat, 10 Dec 2011 22:40:22 +0700")

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> Yeah that slipped in. It should be part of c689332 (Convert many
> resolve_ref() calls to read_ref*() and ref_exists() - 2011-11-13). I
> guess either I missed it or it was a new call site after that patch.
> Split it out as a separate patch?

Yeah, I think it makes sense to split the unrelated part out and place it
early in the series. It seems that you will be updating patch 2 in the
series for __FILE__ anyway so it's not like adding a useless code churn to
do so.

Thanks.

      reply	other threads:[~2011-12-12  8:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-10 12:53 [PATCH 1/3] Convert resolve_ref+xstrdup to new resolve_refdup function Nguyễn Thái Ngọc Duy
2011-12-10 12:53 ` [PATCH 2/3] Guard memory overwriting in resolve_ref's static buffer Nguyễn Thái Ngọc Duy
2011-12-10 21:10   ` Jonathan Nieder
2011-12-11  9:22     ` Nguyen Thai Ngoc Duy
2011-12-10 12:53 ` [PATCH 3/3] Rename resolve_ref() to resolve_ref_unsafe() Nguyễn Thái Ngọc Duy
2011-12-10 20:55   ` Jonathan Nieder
2011-12-11  9:46     ` Nguyen Thai Ngoc Duy
2011-12-10 13:15 ` [PATCH 1/3] Convert resolve_ref+xstrdup to new resolve_refdup function Jonathan Nieder
2011-12-10 15:40   ` Nguyen Thai Ngoc Duy
2011-12-12  8:13     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4nx68ay2.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=wwwjfy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).