git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Fredrik Gustafsson <iveqy@iveqy.com>,
	git@vger.kernel.org, jens.lehmann@web.de
Subject: Re: [PATCH v4 2/2] push: Don't push a repository with unpushed submodules
Date: Thu, 18 Aug 2011 13:32:26 -0700	[thread overview]
Message-ID: <7v4o1ea2at.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110818192157.GA10598@book.hvoigt.net> (Heiko Voigt's message of "Thu, 18 Aug 2011 21:21:58 +0200")

Heiko Voigt <hvoigt@hvoigt.net> writes:

> On Sun, Aug 14, 2011 at 11:03:33AM +0200, Fredrik Gustafsson wrote:
>> When working with submodules it is easy to forget to push a
>> submodule to the server but pushing a super-project that
>> contains a commit for that submodule. The result is that the
>> superproject points at a submodule commit that is not available
>> on the server.
>
> Since I do not see thisi in pu maybe you missed this? There was a series
> containing the same patch send before which Jens asked to ignore but
> this was the one which was meant to be included.

Hmm, this is how the messages look like in my threaded MUA:

  [  34: Fredrik Gustafsson     ] [PATCH v4 0/2] push limitations
   [ 377: Fredrik Gustafsson     ] [PATCH v4 2/2] push: Don't push a reposi...
   [  35: Jens Lehmann           ] Re: [PATCH v4 0/2] push limitations
  [ 377: Fredrik Gustafsson     ] [PATCH v4 2/2] push: Don't push a reposit...
   [  14: Heiko Voigt            ] 

where Jens says "Please ignore this series, it slipped by accident" in the
third one. And the second [PATCH v4 2/2] message that you are reminding me
of (thanks!) has the identical proposed commit log message and patch text
as the other [PATCH v4 2/2] message.

So I am not sure what is going on here.

Also I vaguely recall that I said something about the command line parser
for this new option during the review of the previous round. Has that been
resolved/corrected?

  reply	other threads:[~2011-08-18 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-14  9:03 [PATCH v4 2/2] push: Don't push a repository with unpushed submodules Fredrik Gustafsson
2011-08-18 19:21 ` Heiko Voigt
2011-08-18 20:32   ` Junio C Hamano [this message]
2011-08-19 20:44     ` Heiko Voigt
  -- strict thread matches above, loose matches on Subject: below --
2011-08-14  8:57 [PATCH v4 0/2] push limitations Fredrik Gustafsson
2011-08-14  8:57 ` [PATCH v4 2/2] push: Don't push a repository with unpushed submodules Fredrik Gustafsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4o1ea2at.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=iveqy@iveqy.com \
    --cc=jens.lehmann@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).