From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fix overslow :/no-such-string-ever-existed diagnostics
Date: Tue, 10 May 2011 16:11:22 -0700 [thread overview]
Message-ID: <7v4o52i21x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqfwomffuy.fsf@bauges.imag.fr> (Matthieu Moy's message of "Tue, 10 May 2011 22:41:25 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Is this a complement or an alternative? It seems to me that your other
> patch makes this first one useless (in the sense that the second call is
> always cheap), and avoids complexifying the code of get_sha1_with_mode_1
> for the first call.
I think that the get_sha1_with_mode_1() that is sprinkled with the
"gently" conditional everywhere _is_ the primary source of complexity.
I suspect that if 009fee4 did a proper refactoring, get_sha1_with_mode()
wouldn't have that "gently" option at all, and the die_verify_filename()
wouldn't call get_sha1_with_mode(). Instead, they would share same set of
helper functions and the latter would make a few calls to them, only to
deal with :<path> and <tree>:<path> cases.
prev parent reply other threads:[~2011-05-10 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 18:10 [PATCH] fix overstrict :<path> diagnosis Junio C Hamano
2011-05-10 19:02 ` [PATCH] fix overslow :/no-such-string-ever-existed diagnostics Junio C Hamano
2011-05-10 19:05 ` Re* " Junio C Hamano
2011-05-10 20:41 ` Matthieu Moy
2011-05-10 23:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4o52i21x.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).