git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jared Hance <jaredhance@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Add function per_branch_config.
Date: Wed, 09 Feb 2011 15:27:32 -0800	[thread overview]
Message-ID: <7v4o8cokkb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1297211028-14382-3-git-send-email-jaredhance@gmail.com> (Jared Hance's message of "Tue\,  8 Feb 2011 19\:23\:47 -0500")

Jared Hance <jaredhance@gmail.com> writes:

> Adds a configuration function to be filled up more in the next patch.

Again, "to be filled up more" is not the primary purpose of the new
function that was refactored from the existing one.  State what it does,
and what it is for instead, perhaps like...

    Split a part of the configuration callback into a separate function
    to handle per-branch configuration.

  parent reply	other threads:[~2011-02-09 23:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 20:48 [PATCH v2] Add support for merging from upstream by default Jared Hance
2011-02-08 21:38 ` Jay Soffian
2011-02-08 22:33 ` Jonathan Nieder
2011-02-09  0:04   ` Junio C Hamano
2011-02-09  1:48     ` Jonathan Nieder
2011-02-09  0:23 ` [PATCH v3 0/3] Updated patch series for default upstream merge Jared Hance
2011-02-09  0:23   ` [PATCH v3 1/3] Add setup_merge_commit function to merge/builtin.c Jared Hance
2011-02-09 23:24     ` Junio C Hamano
2011-02-09  0:23   ` [PATCH v3 2/3] Add function per_branch_config Jared Hance
2011-02-09  1:14     ` Jonathan Nieder
2011-02-09 23:27     ` Junio C Hamano [this message]
2011-02-09  0:23   ` [PATCH v3 3/3] Add support for merging from upstream by default Jared Hance
2011-02-09  1:41     ` Jonathan Nieder
2011-02-09  0:34   ` [PATCH v3 0/3] Updated patch series for default upstream merge Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4o8cokkb.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jaredhance@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).