git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	git@vger.kernel.org, Michel Briand <michelbriand@free.fr>
Subject: Re: [PATCH 1/2] t1501: avoid bashisms
Date: Sun, 26 Dec 2010 11:23:07 -0800	[thread overview]
Message-ID: <7v4oa0z6ck.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi=fCa4a-POoMWqnraFjz28-Ko4Yp0fcar+d7AsE@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Sat\, 25 Dec 2010 21\:44\:25 +0700")

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> Junio, please don't pick up this patch.

Won't.  And [2/2] needs to be updated with something like this?

 t/t1501-worktree.sh |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/t/t1501-worktree.sh b/t/t1501-worktree.sh
index 1429a65..8cab065 100755
--- a/t/t1501-worktree.sh
+++ b/t/t1501-worktree.sh
@@ -341,14 +341,10 @@ test_expect_success 'make_relative_path handles double slashes in GIT_DIR' '
 '
 
 test_expect_success 'relative $GIT_WORK_TREE and git subprocesses' '
-	(
-	GIT_DIR=repo.git
-	GIT_WORK_TREE=repo.git/work
-	export GIT_DIR GIT_WORK_TREE
+	GIT_DIR=repo.git GIT_WORK_TREE=repo.git/work \
 	test-subprocess rev-parse --show-toplevel >actual &&
-	echo "`pwd`/repo.git/work" >expected &&
+	echo "$(pwd)/repo.git/work" >expected &&
 	test_cmp expected actual
-	)
 '
 
 test_done

      reply	other threads:[~2010-12-26 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-25 13:57 [PATCH 1/2] t1501: avoid bashisms Nguyễn Thái Ngọc Duy
2010-12-25 13:57 ` [PATCH 2/2] setup_work_tree: adjust relative $GIT_WORK_TREE after moving cwd Nguyễn Thái Ngọc Duy
2010-12-26 11:46   ` [PATCH] " Nguyễn Thái Ngọc Duy
2010-12-26 11:46     ` [PATCH] setup_explicit_git_dir: " Nguyễn Thái Ngọc Duy
2010-12-27  1:26     ` [PATCH] setup_work_tree: " Nguyễn Thái Ngọc Duy
2010-12-25 14:12 ` [PATCH 1/2] t1501: avoid bashisms Andreas Schwab
2010-12-25 14:29   ` Nguyen Thai Ngoc Duy
2010-12-25 14:44     ` Nguyen Thai Ngoc Duy
2010-12-26 19:23       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4oa0z6ck.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=michelbriand@free.fr \
    --cc=pclouds@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).