From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] pack-objects: report actual number of threads to be used
Date: Tue, 07 Apr 2009 23:30:14 -0700 [thread overview]
Message-ID: <7v4owzr72g.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.2.00.0904052311020.6741@xanadu.home
Nicolas Pitre <nico@cam.org> writes:
>> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
>> index 9fc3b35..99181fd 100644
>> --- a/builtin-pack-objects.c
>> +++ b/builtin-pack-objects.c
>> @@ -1612,7 +1612,7 @@ static void ll_find_deltas(struct object_entry
>> **list, unsigned list_size,
>> return;
>> }
>> if (progress > pack_to_stdout)
>> - fprintf(stderr, "Delta compression using %d threads.\n",
>> + fprintf(stderr, "Delta compression using up to %d threads.\n",
>> delta_search_threads);
>>
>> /* Partition the work amongst work threads. */
>
> This I have absolutely no issue with.
>
> Acked-by: Nicolas Pitre <nico@cam.org>
I do not have problem with the wording either, but then the commit log
message needs to change, I think. Care to re-submit?
next prev parent reply other threads:[~2009-04-08 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-04 16:59 [PATCH 1/2] git-repack: use non-dashed update-server-info Dan McGee
2009-04-04 16:59 ` [PATCH 2/2] pack-objects: report actual number of threads to be used Dan McGee
2009-04-04 18:06 ` Jeff King
2009-04-04 18:20 ` Dan McGee
2009-04-04 23:25 ` Jeff King
2009-04-05 0:11 ` Nicolas Pitre
2009-04-06 2:09 ` Dan McGee
2009-04-06 2:31 ` Nicolas Pitre
2009-04-06 2:34 ` Dan McGee
2009-04-06 3:14 ` Nicolas Pitre
2009-04-08 6:30 ` Junio C Hamano [this message]
2009-04-09 15:45 ` [PATCH] Update delta compression message to be less misleading Dan McGee
2009-04-11 19:24 ` Junio C Hamano
2009-04-11 19:42 ` Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4owzr72g.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).