git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Jakub Narebski <jnareb@gmail.com>,
	git@vger.kernel.org, "Eric S. Raymond" <esr@thyrsus.com>
Subject: Re: Comments on "Understanding Version Control" by Eric S. Raymond
Date: Wed, 04 Feb 2009 16:04:43 -0800	[thread overview]
Message-ID: <7v4oz9lpes.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090204235436.GA8945@mit.edu> (Theodore Tso's message of "Wed, 4 Feb 2009 18:54:36 -0500")

Theodore Tso <tytso@mit.edu> writes:

> 1) In branch A, the directory src/plugin/innodb-experimental is
>    renamed to src/plugin/innodb, and in branch B, a commit (i)
>    modifies a file src/plugin/innodb-experimental/table.c, and (ii)
>    creates a file src/plugin/innodb-experimental/mod-schema.c.  This
>    commit in branch B is then pulled into branch A, where the
>    directory rename has taken place.  The user may not know that a
>    directory rename had taken place under the covers, so they don't
>    give any magic options when they run the "git cherry-pick" or "git
>    merge" command.  Does the right thing happen such that the right
>    file in src/plugin/innodb is modified, and the new file is created
>    in src/plugin/innodb, even though in the original commit, the
>    changes were made to files in src/plugin/innodb-experimental?

Careful.

Although it is reasonable to expect that existing file's modification will
move to innodb/ directory, it is not as clear-cut as some people seem to
assume that the new file should always be created in the new directory
innodb/.  You seem to imply you understand the issues by having the second
example, though.

  reply	other threads:[~2009-02-05  0:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 18:48 Comments on "Understanding Version Control" by Eric S. Raymond Jakub Narebski
2009-02-02 20:24 ` Theodore Tso
2009-02-02 20:35   ` Eric S. Raymond
2009-02-03 20:57     ` Jakub Narebski
2009-02-04  2:04   ` Jakub Narebski
2009-02-04 23:54     ` Theodore Tso
2009-02-05  0:04       ` Junio C Hamano [this message]
2009-02-05  2:43         ` Theodore Tso
2009-02-05  6:24           ` Junio C Hamano
2009-02-05 13:28             ` Theodore Tso
2009-02-05 23:06               ` Junio C Hamano
2009-02-05  0:08       ` Jakub Narebski
2009-02-05  0:49         ` Theodore Tso
2009-02-05  6:01       ` Miles Bader
2009-02-05  9:34         ` Eric S. Raymond
2009-02-05 11:23       ` Jakub Narebski
2009-02-05 13:16         ` Theodore Tso
2009-02-05 17:36           ` Jakub Narebski
2009-02-05 21:45             ` Theodore Tso
2009-02-04 22:14 ` Tests for " Jakub Narebski
2009-02-10  1:20 ` Comments on " Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4oz9lpes.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=esr@thyrsus.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).