From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems
Date: Tue, 03 Feb 2009 18:09:54 -0800 [thread overview]
Message-ID: <7v4ozb9clp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.DEB.1.00.0902032132130.9822@pacific.mpi-cbg.de
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I inspected all files that git grep -p showed me, and I see that t3412
> uses the file names, but passes explicit parameters to test_commit for
> them. So that is fine, too.
>
> Just as a matter of preference, I'd not downcase, but instead append a
> ".file" in test_commit, but that's not a strong preference. (I'd not
> downcase, because that was done only to prevent the tag to have the same
> name as the file, but that did not work...)
Agreed, there is no point to downcase the name.
prev parent reply other threads:[~2009-02-04 2:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 16:00 [PATCH] t3411: Fix test 1 for case-insensitive file systems Brian Gernhardt
2009-01-29 16:13 ` Johannes Schindelin
2009-01-29 17:19 ` Junio C Hamano
2009-01-29 17:33 ` Johannes Schindelin
2009-01-29 19:10 ` Brian Gernhardt
2009-02-03 15:07 ` Brian Gernhardt
2009-02-03 16:53 ` Johannes Schindelin
2009-02-03 17:11 ` Brian Gernhardt
2009-02-03 17:18 ` Johannes Schindelin
2009-02-03 17:43 ` Brian Gernhardt
2009-02-03 18:19 ` Johannes Schindelin
2009-02-03 18:42 ` Brian Gernhardt
2009-02-03 19:02 ` Junio C Hamano
2009-02-03 19:12 ` Brian Gernhardt
2009-02-03 20:16 ` Johannes Schindelin
2009-02-03 20:38 ` Johannes Schindelin
2009-02-04 2:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4ozb9clp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).