git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kjetil Barvik <barvik@broadpark.no>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c
Date: Sun, 11 Jan 2009 21:39:37 -0800	[thread overview]
Message-ID: <7v4p05krqe.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1231699002-5316-1-git-send-email-barvik@broadpark.no

Kjetil Barvik <barvik@broadpark.no> writes:

> diff --git a/diff-lib.c b/diff-lib.c
> index ae96c64ca209f4df9008198e8a04b160bed618c7..e6d1d2b34147a13aadb5019e0c8336ef5f56ee39 100644
> --- a/diff-lib.c
> +++ b/diff-lib.c
> ...
> @@ -344,8 +334,7 @@ static void do_oneway_diff(struct unpack_trees_options *o,
>  	struct cache_entry *idx,
>  	struct cache_entry *tree)
>  {
> -	struct oneway_unpack_data *cbdata = o->unpack_data;
> -	struct rev_info *revs = cbdata->revs;
> +	struct rev_info *revs = o->unpack_data;;

Thanks; I'll clean-up the extra semicolon and apply.

      parent reply	other threads:[~2009-01-12  5:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 18:36 [PATCH] Cleanup of unused symcache variable inside diff-lib.c Kjetil Barvik
2009-01-11 18:45 ` Johannes Schindelin
2009-01-11 19:32   ` Kjetil Barvik
2009-01-11 19:46     ` Johannes Schindelin
2009-01-11 20:09       ` Kjetil Barvik
2009-01-11 20:17         ` Johannes Schindelin
2009-01-11 20:50           ` Kjetil Barvik
2009-01-11 22:25             ` Junio C Hamano
2009-01-11 22:23         ` Junio C Hamano
2009-01-12  5:39 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4p05krqe.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barvik@broadpark.no \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).