git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: jidanni@jidanni.org
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root
Date: Sat, 27 Dec 2008 14:15:33 -0800	[thread overview]
Message-ID: <7v4p0pcliy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: E1LGfLz-0001nM-AO@jidanni.org

jidanni@jidanni.org writes:

> @@ -209 +209 @@ project:
> -$ git format-patch \--root origin
> +$ git format-patch --root origin

I thought these backslashes before double-dash are protecting the latter
from being turned into em-dashes.  I do not see any weird backslash in the
"git help" (aka "manpage") output nor in the HTML documentation, e.g.

    http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html

without your patch, so I have to say that this chunk is a useless churn.

All of your three patches lack context, which is essential enabler for
easier review.  They have "diff --git" header, but are not made relative
to the root of the project tree (i.e. lack "Documentation/" prefix), which
is the norm for both the tool and for this project and this mailing list.

I guess that you may be experimenting with various options to see how they
work, and the curiosity by itself is a good thing, but please do not make
other people suffer with results from such experiments by sending patches
in nonstandard forms.

By submitting a patch to try improving the system, you are already making
a difference in substance.  Please do not try to be creative in form.  It
only makes lives of other people unnecessarily harder with no real reason
and wastes other people's time.  And it wastes yours, too.  A patch
conforming to the norm is much easier to review, comment on and apply.
Ok?

"Don't try to be different in form, make a difference in substance" also
applies to your S-o-b line, by the way.

  reply	other threads:[~2008-12-27 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-27 19:57 [PATCH] Documentation/git-format-patch.txt: fix weird backslash at --root jidanni
2008-12-27 22:15 ` Junio C Hamano [this message]
2008-12-27 22:36   ` jidanni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4p0pcliy.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).