From: Junio C Hamano <gitster@pobox.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCHv5 2/3] gitweb: add patches view
Date: Wed, 17 Dec 2008 22:09:05 -0800 [thread overview]
Message-ID: <7v4p12hv5q.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1229422290-6213-3-git-send-email-giuseppe.bilotta@gmail.com> (Giuseppe Bilotta's message of "Tue, 16 Dec 2008 11:11:29 +0100")
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> sub git_commitdiff {
> my $format = shift || 'html';
> + my %params = @_;
> ...
> + if ($params{-single}) {
> + push @commit_spec, '-1';
> + } else {
> + if ($patch_max > 0) {
> ...
> + }
> @@ -5625,6 +5635,10 @@ sub git_commitdiff_plain {
>
> # format-patch-style patches
> sub git_patch {
> + git_commitdiff('patch', -single=> 1);
> +}
Hmm, if you are changing the interface this way, wouldn't it make more
sense to also do this?
git_commitdiff(--format => 'patch', --single => 1);
git_commitdiff(--format => 'html');
next prev parent reply other threads:[~2008-12-18 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 10:11 [PATCHv5 0/3] gitweb: patch view Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 1/3] gitweb: add " Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 2/3] gitweb: add patches view Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 3/3] gitweb: link to patch(es) view in commit(diff) and (short)log view Giuseppe Bilotta
2008-12-18 6:09 ` Junio C Hamano [this message]
2008-12-18 9:33 ` [PATCHv5 2/3] gitweb: add patches view Jakub Narebski
2008-12-18 16:23 ` Giuseppe Bilotta
2008-12-18 17:28 ` Jakub Narebski
2008-12-18 19:15 ` Junio C Hamano
2008-12-18 19:44 ` Jakub Narebski
2008-12-18 18:15 ` Jakub Narebski
2008-12-18 19:57 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4p12hv5q.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).