Re: git commit -v does not removes the patch

[Junio C Hamano <gitster@pobox.com>]

SZEDER Gábor <szeder@ira.uka.de> writes:

> So, I wonder whether those '--no-verify' options are still required in
> 'git rebase -i'.

The use of --no-verify there does not have anything to do with "whitespace
errors".  It is to override _any_ validation the users want to do when
using "git commit" in their interactive workflow.  It so happens that the
example hook we ship demonstrates how you hunt for whitespace errors, but
you have to remember that it is just an example.

We may want to disable the checking of exit status from commit-msg hook
while still calling the hook itself, though.  The primary purpose of the
hook is to allow users to reformat (say, passing "fmt -64") the message,
but it is allowed to interfere and that was meant to happen when using
"git commit" but we probably do not want it when rebasing.

Further, we also may want to make the use of --no-verify overridable from
the command line when running rebase.  The primary purpose of the rebase
command is to transplant a sequence of commits to someplace else without
molesting its contents and message unnecessarily, and --no-verify is a
good thing to use in general for that reason, but people may sometimes
want to use it as a way to clean up the changes.