From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Alex Bennee <kernel-hacker@bennee.com>, git@vger.kernel.org
Subject: Re: Adding Reviewed-by/Tested-by tags to other peoples commits
Date: Sat, 11 Oct 2008 04:28:46 -0700 [thread overview]
Message-ID: <7v4p3jl6a9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081011074604.GA23883@sigill.intra.peff.net> (Jeff King's message of "Sat, 11 Oct 2008 03:46:04 -0400")
Jeff King <peff@peff.net> writes:
> On Sat, Oct 11, 2008 at 07:37:04AM +0100, Alex Bennee wrote:
>
>> I've just tested/reviewed a patch of someone elses and I want to
>> forward it on the appropriate mailing list. I gather for Linux you
>> just add the appropriate tags to the commit. Does git offer a shortcut
>> for doing this or do you have to do a reset HEAD^ and re-commit with a
>> copy&pasted and modified commit message?
>
> Try "git commit --amend" to edit the commit message. There's no
> automatic way of adding acked-by or tested-by tags with git; most people
> who do those things often would probably configure their editor to make
> it easier.
These Distimmed-by: fields are cumulative in nature, so once recorded in a
commit log message you cannot add new ones without amending, which means
you cannot exchange such commits by pushing or pulling but by forwarding
patches via e-mails. I thought people added these in their MUAs. IOW, I
share your "would probably" with s/editor/MUA/.
next prev parent reply other threads:[~2008-10-11 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 6:37 Adding Reviewed-by/Tested-by tags to other peoples commits Alex Bennee
2008-10-11 7:46 ` Jeff King
2008-10-11 10:58 ` Johannes Schindelin
2008-10-11 11:28 ` Junio C Hamano [this message]
2008-10-11 10:42 ` Johannes Schindelin
2008-10-11 11:48 ` Junio C Hamano
2008-10-11 13:06 ` Johannes Schindelin
2008-10-11 21:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4p3jl6a9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kernel-hacker@bennee.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).