From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael Dressel <MichaelTiloDressel@t-online.de>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration
Date: Wed, 03 Sep 2008 13:10:12 -0700 [thread overview]
Message-ID: <7v4p4xat3v.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080903191217.GA31195@coredump.intra.peff.net> (Jeff King's message of "Wed, 3 Sep 2008 15:12:17 -0400")
Jeff King <peff@peff.net> writes:
>> git log --pretty=format:'%H (%d) %s'
>
> I think Junio requested the enclosing parentheses be included. I am not
> sure I agree, but we are already mandating the comma separator.
> Personally, I think the right solution is more like
>
> %(decorate:delim=, )
>
> but that is a much bigger change (and part of what was holding me up on
> just improving this patch). I think adding %d in the meantime (with or
> without the surrounding parentheses) is reasonable.
I agree with the above reasoning. If we go with surrounding parentheses,
it might even make sense to include a SP _before_ the opening parenthesis,
so that "%h %s%d" expands to either of these:
$ git show -s --pretty=format:'%h %s%d' v1.6.0^0 v1.6.0^1
ea02eef GIT 1.6.0 (refs/tags/v1.6.0)
373a273 Merge git-gui 0.11.0
Also I did not like the bug to misidentify "git log --grep=pretty=format:"
you pointed out in your message.
next prev parent reply other threads:[~2008-09-03 20:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 18:40 [PATCH 1/2] add '%d' pretty format specifier to show decoration Michael Dressel
2008-09-03 19:12 ` Jeff King
2008-09-03 20:10 ` Junio C Hamano [this message]
2008-09-03 20:36 ` Jeff King
2008-09-03 20:59 ` Junio C Hamano
2008-09-03 21:04 ` Jeff King
2008-09-03 22:06 ` René Scharfe
2008-09-04 3:51 ` Jeff King
2008-09-04 15:47 ` René Scharfe
2008-09-04 21:38 ` [PATCH 1/3] log: add load_ref_decorations() René Scharfe
2008-09-04 21:39 ` [PATCH 2/3] move load_ref_decorations() to log-tree.c and export it René Scharfe
2008-09-04 21:40 ` [PATCH 3/3] add '%d' pretty format specifier to show decoration René Scharfe
2008-09-05 0:11 ` Jeff King
2008-09-05 0:28 ` Junio C Hamano
2008-09-05 0:37 ` Jeff King
2008-09-05 0:41 ` Junio C Hamano
2008-09-05 18:38 ` Michael Dressel
2008-09-09 17:33 ` Michael Dressel
2008-09-09 20:15 ` René Scharfe
2008-09-05 16:14 ` René Scharfe
2008-09-03 19:17 ` [PATCH 1/2] " Jeff King
2008-09-03 20:06 ` Michael Dressel
2008-09-03 20:33 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4p4xat3v.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).