git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "David Tweed" <david.tweed@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	git@vger.kernel.org
Subject: Re: About git pretty
Date: Fri, 22 Aug 2008 17:12:53 -0700	[thread overview]
Message-ID: <7v4p5c612y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <e1dab3980808221704h3c713e64n41adc631d7a79601@mail.gmail.com> (David Tweed's message of "Sat, 23 Aug 2008 01:04:09 +0100")

"David Tweed" <david.tweed@gmail.com> writes:

> On Sat, Aug 23, 2008 at 12:41 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> "Felipe Contreras" <felipe.contreras@gmail.com> writes:
>>> It is just me or 'pretty full' doesn't exactly convey the meaning of
>>> the action to execute?
> [snip]
>>> If you like the idea I can work on a patch.
>>
>> FWIW, I don't like it.
>
> It's probably much too late to change conventions given the number of
> deployed scripts, but one of the annoyances for me about git is that a
> lot of the commands/options names are based on what the code does/is
> written rather than relating to what a user who doesn't know or care
> about the inner workings expects as output. For instance, I imagine
> the --pretty gets its name because a pretty printing routine, called
> pretty_print_commit in the code,...

It's the other way around.  We name function pretty_print_commit() because
we would want to pretty print out output and the option to trigger the
behaviour then is named --pretty.

  reply	other threads:[~2008-08-23  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 23:24 About git pretty Felipe Contreras
2008-08-22 23:41 ` Junio C Hamano
2008-08-23  0:04   ` David Tweed
2008-08-23  0:12     ` Junio C Hamano [this message]
2008-08-23  0:34       ` David Tweed
2008-08-23  0:38         ` David Tweed
2008-08-23  0:03 ` Stephan Beyer
2008-08-23 18:57   ` Felipe Contreras
2008-08-24 17:49     ` Johannes Schindelin
2008-08-30 16:30       ` Junio C Hamano
2009-02-21 15:31         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4p5c612y.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=david.tweed@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).