git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jim Meyering <jim@meyering.net>
Cc: git list <git@vger.kernel.org>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH] add boolean diff.suppress-blank-empty config option
Date: Fri, 15 Aug 2008 11:28:38 -0700	[thread overview]
Message-ID: <7v4p5mb0a1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87k5eiphro.fsf@rho.meyering.net> (Jim Meyering's message of "Fri, 15 Aug 2008 14:47:07 +0200")

Jim Meyering <jim@meyering.net> writes:

> GNU diff's --suppress-blank-empty option makes it so that diff does not
> add a space or tab before each empty output line of context.  With this
> option, empty context lines are empty also in "git diff" output.

AFAIK, ERN 103/120 inspired by your comment merely says an empty context
is either an empty line or a line with a single space on it and does not
deprecate the latter, more traditional, form (I do not know the current
status of the update to the POSIX --- what's the recommended way to find
it out by outsiders?)

We've hacked the patch application side to accomodate this special case to
grok output from recent GNU diff already.  Can't we just stop at that,
without having to do the same for generation side?  What's the downside of
not doing so?

  reply	other threads:[~2008-08-15 18:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 12:47 [PATCH] add boolean diff.suppress-blank-empty config option Jim Meyering
2008-08-15 18:28 ` Junio C Hamano [this message]
2008-08-16 11:07   ` Jim Meyering
2008-08-18 20:20 ` Junio C Hamano
2008-08-19 13:29   ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4p5mb0a1.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=eggert@cs.ucla.edu \
    --cc=git@vger.kernel.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).