git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stephan Beyer <s-beyer@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only
Date: Tue, 15 Jul 2008 22:54:25 -0700	[thread overview]
Message-ID: <7v4p6qwezy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080716051829.GB4030@segfault.peff.net> (Jeff King's message of "Wed, 16 Jul 2008 01:18:29 -0400")

Jeff King <peff@peff.net> writes:

> This is probably a fine protective measure, and it looks like Junio has
> already applied it. But shouldn't any git commands returning such values
> be fixed? Which commands return such bogus error codes?

Anything that returns error() from its cmd_xxx() routine, for example,
would end up exiting with (-1).  Is it "such bogus" error codes, though?

I am somewhat tired tonight, so I'll leave it up to the list to do the
grepping and go to bed ;-)

  reply	other threads:[~2008-07-16  5:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 15:47 [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Stephan Beyer
2008-07-12 15:47 ` [PATCH 2/2] t/: Use "test_must_fail git" instead of "! git" Stephan Beyer
2008-07-12 16:04   ` Jakub Narebski
2008-07-12 21:43     ` Stephan Beyer
2008-07-12 21:30   ` [SQUASH PATCH] t9001: " Stephan Beyer
2008-07-16  5:18 ` [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only Jeff King
2008-07-16  5:54   ` Junio C Hamano [this message]
2008-07-17  5:18     ` Jeff King
2008-07-17  5:38       ` Junio C Hamano
2008-07-17  6:01         ` Jeff King
2008-07-17  6:31           ` Junio C Hamano
2008-07-17  6:38             ` Jeff King
2008-07-17  7:22               ` Johannes Sixt
2008-07-17  7:25                 ` Junio C Hamano
2008-07-16 11:57   ` Stephan Beyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4p6qwezy.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).