* [PATCH] run_command(): respect GIT_TRACE
@ 2008-07-07 13:41 Johannes Schindelin
2008-07-07 20:00 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin @ 2008-07-07 13:41 UTC (permalink / raw)
To: git, gitster
When GIT_TRACE is set, the user is most likely wanting to see an external
command that is about to be executed.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
run-command.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/run-command.c b/run-command.c
index 2ce8c2b..6e29fdf 100644
--- a/run-command.c
+++ b/run-command.c
@@ -65,6 +65,8 @@ int start_command(struct child_process *cmd)
cmd->err = fderr[0];
}
+ trace_argv_printf(cmd->argv, "trace: run_command:");
+
#ifndef __MINGW32__
cmd->pid = fork();
if (!cmd->pid) {
--
1.5.6.2.402.g95b5ab.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] run_command(): respect GIT_TRACE
2008-07-07 13:41 [PATCH] run_command(): respect GIT_TRACE Johannes Schindelin
@ 2008-07-07 20:00 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-07-07 20:00 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> When GIT_TRACE is set, the user is most likely wanting to see an external
> command that is about to be executed.
I haven't checked to see if none of the callers of start_command() assumes
the current behaviour and is printing this information itself instead, but
other than that, your justification feels very sensible.
Thanks.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> run-command.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/run-command.c b/run-command.c
> index 2ce8c2b..6e29fdf 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -65,6 +65,8 @@ int start_command(struct child_process *cmd)
> cmd->err = fderr[0];
> }
>
> + trace_argv_printf(cmd->argv, "trace: run_command:");
> +
> #ifndef __MINGW32__
> cmd->pid = fork();
> if (!cmd->pid) {
> --
> 1.5.6.2.402.g95b5ab.dirty
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-07 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-07 13:41 [PATCH] run_command(): respect GIT_TRACE Johannes Schindelin
2008-07-07 20:00 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).