Re: [PATCH 1/4] Add history graph API

[Junio C Hamano <gitster@pobox.com>]

Adam Simpkins <adam@adamsimpkins.net> writes:

> On Sun, Apr 06, 2008 at 10:06:24PM +0100, Johannes Schindelin wrote:
>> 
>> On Sun, 6 Apr 2008, Adam Simpkins wrote:
>> 
>> > +/* Defined in commit.h */
>> > +struct commit;
>> > +/* Defined in strbuf.h */
>> > +struct strbuf;
>> 
>> You do not need those.
>
> I added them so that graph.h can be included without including any
> other header files first.  They can be taken out if we assume that all
> users of graph.h will include commit.h and strbuf.h first.

The current practice is we expect .c files to include necessary .h files
themselves and avoid including .h files from others (I do not personally
necessarily agree with this practice, by the way, but that is the way it
is).  So please drop them.

> Sorry, force of habit.  I tried to remember to use postfix in most
> places, but I guess I forgot in that place.

We seem to consistently use postfix when increment is done only for its
side effect.