Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, kenneth johansson <ken@kenjo.org>
Subject: Re: tracking repository
Date: Sun, 16 Mar 2008 17:17:24 -0700	[thread overview]
Message-ID: <7v4pb6dx0r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0803161904360.19665@iabervon.org> (Daniel Barkalow's message of "Sun, 16 Mar 2008 19:11:48 -0400 (EDT)")

Daniel Barkalow <barkalow@iabervon.org> writes:

> On Sun, 16 Mar 2008, Junio C Hamano wrote:
> ...
>> ...  It still has an independent issue
>> that this is now called by "git remote show" or "git remote prune", and it
>> will die with a nonsense "refusing to create" error message, though.
>> 
>> The error, as far as I can tell, is half about a misconfigured config
>> (e.g. "fetch = refs/heads/*:refs/remotes/[]?/*") and half about screwy
>> remote repository (e.g. a misnamed "[]?" branch on the remote end can try
>> to update a broken "refs/remotes/origin/[]?" even the configuration is a
>> perfectly valid "fetch = refs/heads/*:refs/remotes/origin/*").  It may
>> make sense to reword the error message to "ignoring" from "refusing" and
>> do just that without dying here.  I dunno.
>
> Yeah, I think that's right. (And this patch is also right)

Which means that an error checking (i.e. dying) needs to be added to
whatever reads from config to find "refs/heads/*:refs/remotes/[]?/*" to
cover the first half.  That's an configuration error and we should not
just say "ignoring" but actively urge the user to correct, no?

  reply	other threads:[~2008-03-17  0:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15 19:35 tracking repository kenneth johansson
2008-03-16  2:42 ` Junio C Hamano
2008-03-16 20:02   ` kenneth johansson
2008-03-16 20:38     ` Junio C Hamano
2008-03-16 21:28       ` Daniel Barkalow
2008-03-16 21:57         ` Junio C Hamano
2008-03-16 22:18           ` Daniel Barkalow
2008-03-16 22:30             ` Junio C Hamano
2008-03-16 23:01               ` Junio C Hamano
2008-03-16 23:11                 ` Daniel Barkalow
2008-03-17  0:17                   ` Junio C Hamano [this message]
2008-03-17  0:35         ` Junio C Hamano
2008-03-17  2:13           ` Daniel Barkalow
2008-03-17  2:37           ` Daniel Barkalow
2008-03-17  7:48             ` Junio C Hamano
2008-03-17 16:23               ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4pb6dx0r.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=ken@kenjo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox