From: Junio C Hamano <gitster@pobox.com>
To: Frank Lichtenheld <frank@lichtenheld.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] gc: Add --quiet option
Date: Sat, 01 Mar 2008 12:24:55 -0800 [thread overview]
Message-ID: <7v4pbqyyy0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1204322019-17788-1-git-send-email-frank@lichtenheld.de
Frank Lichtenheld <frank@lichtenheld.de> writes:
> @@ -49,6 +49,9 @@ OPTIONS
> required; if not, it exits without performing any work.
> Some git commands run `git gc --auto` after performing
> operations that could create many loose objects.
> +
> +--quiet::
> + Suppress all progress reports.
> +
> Housekeeping is required if there are too many loose objects or
> too many packs in the repository. If the number of loose objects
Read the surrounding text again. "Housekeeping is..." is talking about
the --auto option.
I'll move the description of --quiet a bit down.
> @@ -197,6 +199,9 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
> append_option(argv_repack, buf, MAX_ADD);
> }
> }
> + if (quiet) {
> + append_option(argv_repack, "-q", MAX_ADD);
> + }
No { } around a single statement.
No need to resend, as I've already munged your patch and applied.
Thanks.
prev parent reply other threads:[~2008-03-01 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 21:53 [PATCH] gc: Add --quiet option Frank Lichtenheld
2008-03-01 20:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pbqyyy0.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).