From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size
Date: Sat, 12 Jan 2008 11:17:15 -0800 [thread overview]
Message-ID: <7v4pdiua4k.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46dff0320801120151s7959edddp1e1f8b506da79e4e@mail.gmail.com> (Ping Yin's message of "Sat, 12 Jan 2008 17:51:43 +0800")
"Ping Yin" <pkufranky@gmail.com> writes:
> On Jan 12, 2008 4:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ping Yin <pkufranky@gmail.com> writes:
>>
>> > @@ -265,6 +267,10 @@ set_name_rev () {
>> > #
>> > modules_summary()
>> > {
>> > + summary_limit=${summary_limit:-1000000}
>>
>> Why a million?
> Because i think a million is big enough. I'd better define a constant
> for unlimited number.
I think that is a wrong approach to begin with. You are
assuming that you will always limit and by using improbably
large limit to pretend it is unlimited. Why not making the
summary list generator truely capable of produce an unlimited
list?
I also think using 100 or so as a sane default, allowing the
user to override to say "I do not want any limitation", is a
much better default.
next prev parent reply other threads:[~2008-01-12 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 7:37 [PATCH 0/5] submodule summary support Ping Yin
2008-01-12 7:37 ` [PATCH 1/5] git-submodule: New subcommand 'summary' (1) - code framework Ping Yin
2008-01-12 7:37 ` [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work Ping Yin
2008-01-12 7:37 ` [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size Ping Yin
2008-01-12 7:37 ` [PATCH 4/5] git-status: submodule summary support Ping Yin
2008-01-12 7:37 ` [PATCH 5/5] git-status: configurable submodule summary size Ping Yin
2008-01-12 8:36 ` [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit " Junio C Hamano
2008-01-12 9:51 ` Ping Yin
2008-01-12 19:17 ` Junio C Hamano [this message]
2008-01-13 6:38 ` Ping Yin
2008-01-12 8:32 ` [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work Junio C Hamano
2008-01-12 9:48 ` Ping Yin
2008-01-12 12:24 ` Ping Yin
2008-01-12 19:21 ` Junio C Hamano
2008-01-12 11:12 ` Ping Yin
2008-01-12 19:25 ` Junio C Hamano
2008-01-13 6:28 ` Ping Yin
2008-01-12 8:18 ` [PATCH 1/5] git-submodule: New subcommand 'summary' (1) - code framework Junio C Hamano
2008-01-12 9:09 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pdiua4k.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).