From: Junio C Hamano <gitster@pobox.com>
To: "Hannes Eder" <hannes.eder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] allow a single form feed in pre commit hook
Date: Tue, 18 Dec 2007 02:18:08 -0800 [thread overview]
Message-ID: <7v4peg1f33.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <5d2716640712180147x36aa3178ja8658e30842c4e52@mail.gmail.com> (Hannes Eder's message of "Tue, 18 Dec 2007 10:47:27 +0100")
"Hannes Eder" <hannes.eder@gmail.com> writes:
> It's not uncommon to have a lines with a single form feed in it, e.g.
> the default GPL COPYING and also in .c files and others. Attached
> patch allows this in the pre-commit hook.
Hmm. The current trend is to get rid of the whitespace checks from this
hook and enrich git-diff --check and git-apply --whitespace=error.
I've been planning to add a new whitespace error rule that allows ^M at
the end of line, post 1.5.4. Another rule that allows a lone ^L would
match what you are doing here, and it would be a good addition as well.
next prev parent reply other threads:[~2007-12-18 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 9:47 [PATCH] allow a single form feed in pre commit hook Hannes Eder
2007-12-18 10:18 ` Junio C Hamano [this message]
2007-12-18 10:27 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2007-12-18 10:09 Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4peg1f33.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hannes.eder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).