From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] Fix XML parser leaks in http-push
Date: Tue, 11 Dec 2007 14:36:36 -0800 [thread overview]
Message-ID: <7v4peodfkb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1197412253-927-1-git-send-email-mh@glandium.org> (Mike Hommey's message of "Tue, 11 Dec 2007 23:30:53 +0100")
Mike Hommey <mh@glandium.org> writes:
> XML_Parser were never freed. While at it, move the parser initialization to
> right before it is needed.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>
> This one is the same, but against pu, where Junio fixed my strbuf patch in
> a different way than I did.
To be very honest, I wish the strbuf patch (that has potentially larger
impact) did not take these obviously correct leakfix patches hostage.
Will have to take a look but slowly (I'm at work now).
next prev parent reply other threads:[~2007-12-11 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 21:19 [PATCH 1/2] Fix XML parser leaks in http-push Mike Hommey
2007-12-11 21:19 ` [PATCH 2/2] Fix some memory leaks in various places Mike Hommey
2007-12-11 21:59 ` [PATCH 3/2] Fix small memory leaks induced by diff_tree_setup_paths Mike Hommey
2007-12-11 22:30 ` [PATCH 1/2 v2] Fix XML parser leaks in http-push Mike Hommey
2007-12-11 22:36 ` Junio C Hamano [this message]
2007-12-11 22:50 ` [PATCH 1/2 for master] " Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4peodfkb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).