From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: t7005 and vi in GIT_EXEC_PATH Date: Sun, 11 Nov 2007 13:29:01 -0800 Message-ID: <7v4pfscvz6.fsf@gitster.siamese.dyndns.org> References: <9A9986E7-E03D-458A-9A19-A3EF0E7B203D@silverinsanity.com> <7v3avcefg9.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Johannes Schindelin , Git Mailing List To: Brian Gernhardt X-From: git-owner@vger.kernel.org Sun Nov 11 22:29:27 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IrKMw-0004ce-8S for gcvg-git-2@gmane.org; Sun, 11 Nov 2007 22:29:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754406AbXKKV3L (ORCPT ); Sun, 11 Nov 2007 16:29:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754387AbXKKV3K (ORCPT ); Sun, 11 Nov 2007 16:29:10 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:57430 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406AbXKKV3J (ORCPT ); Sun, 11 Nov 2007 16:29:09 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 9935D2FA; Sun, 11 Nov 2007 16:29:30 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id A5D8294749; Sun, 11 Nov 2007 16:29:26 -0500 (EST) In-Reply-To: <7v3avcefg9.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 11 Nov 2007 11:43:02 -0800") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > Brian Gernhardt writes: > >> I'm sorry, I should have been more clear. I was referring to the >> GIT_EXEC_PATH build variable, not the environment variable. The git >> wrapper always adds the path determined during build to the front of >> PATH. When I was changing my build script, this got set to "/usr/ >> local/bin" (I usually use /usr/local/stow/git, instead). Since I have >> a /usr/local/bin/vim, PATH for git-commit.sh during the test was: >> >> - my git build directory >> - /usr/local/bin (containing a symlink vi -> vim) >> - the t/trash directory, added by the test via `PATH=".:$PATH"` >> (containing the test vi script) >> - my normal path > > Maybe that is what is broken. t/test-lib.sh makes the > environment variable point at the build directory, and that > should override the path that is compiled in, shouldn't it? Ah, nevermind. I did not see the other messages in the thread.