* [PATCH] Unquote From line from patch before comparing with given from address.
@ 2007-06-11 17:04 Kristian Høgsberg
2007-06-12 5:28 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Kristian Høgsberg @ 2007-06-11 17:04 UTC (permalink / raw)
To: git
This makes --suppress-from actually work when you're unfortunate enough
to have non-ASCII in your name. Also, if there's a match use the optionally
RFC2047 quoted version from the email.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---
git-send-email.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index eb876f8..7c0c90b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -561,7 +561,8 @@ foreach my $t (@files) {
$subject = $1;
} elsif (/^(Cc|From):\s+(.*)$/) {
- if ($2 eq $from) {
+ if (unquote_rfc2047($2) eq $from) {
+ $from = $2;
next if ($suppress_from);
}
elsif ($1 eq 'From') {
--
1.5.2.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Unquote From line from patch before comparing with given from address.
2007-06-11 17:04 [PATCH] Unquote From line from patch before comparing with given from address Kristian Høgsberg
@ 2007-06-12 5:28 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2007-06-12 5:28 UTC (permalink / raw)
To: Kristian Høgsberg; +Cc: git
Thanks.
That has been longstanding, and I hinted how that can be fixed a
couple of times on the list, and was waiting for somebody for
whom fixing it would make a difference to fix it, while sort of
pretending to be lazy.
Happy to see finally somebody stepped forward ;-).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-12 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-11 17:04 [PATCH] Unquote From line from patch before comparing with given from address Kristian Høgsberg
2007-06-12 5:28 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).