From: Junio C Hamano <junkio@cox.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make the installation targets a little less chatty
Date: Thu, 31 May 2007 17:12:04 -0700 [thread overview]
Message-ID: <7v4pls1qjv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070531222313.GA12204@steel.home> (Alex Riesen's message of "Fri, 1 Jun 2007 00:23:13 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> by default. V=1 works as usual.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> Now it quite quiet. I tried top show every installed file, but it
> wasn't an improvement at all so I decided to just show what's being
> done.
I agree that the long single line that installs the commands to $(bindir)
may be somewhat annoying.
Cleaning up compilation step is one thing; by tidying up the
output it makes compiler warnings stand out.
But I do not like playing games like this in general in
installation rule. An excerpt from your patch:
> + @echo installing programs
> + $(QUIET)$(foreach p,$(BUILT_INS), rm -f ...
This would not even let you see what got installed. At least,
less verbose compilation step we have these days lets you see
what is being built. I certainly would not object if the output
would look like this, though:
CC builtin-cat-file.o
...
GEN git-add--interactive
...
LINK git-http-push
...
BUILTIN git-add
...
MKDIR -p /usr/local/bin
INSTALL git-foo
INSTALL git-bar
...
INSTALL templates/description
INSTALL templates/hooks/post-update
...
next prev parent reply other threads:[~2007-06-01 0:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 22:23 [PATCH] Make the installation targets a little less chatty Alex Riesen
2007-06-01 0:12 ` Junio C Hamano [this message]
2007-06-01 7:35 ` Alex Riesen
2007-06-01 23:09 ` Alex Riesen
2007-06-02 19:58 ` Junio C Hamano
2007-06-03 11:43 ` Alex Riesen
-- strict thread matches above, loose matches on Subject: below --
2007-06-03 1:00 quieter installs Shawn O. Pearce
2007-06-03 13:07 ` [PATCH] Make the installation targets a little less chatty Alex Riesen
2007-06-04 7:48 ` Junio C Hamano
2007-06-04 14:00 ` Alex Riesen
2007-06-04 17:40 ` Johannes Schindelin
2007-06-05 10:33 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pls1qjv.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).