git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: gitzilla@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix tail option problem in test
Date: Mon, 23 Apr 2007 17:09:38 -0700	[thread overview]
Message-ID: <7v4pn6d459.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <462D47CA.7010806@gmail.com> (A. Large Angry's message of "Mon, 23 Apr 2007 19:56:58 -0400")

A Large Angry SCM <gitzilla@gmail.com> writes:

> The tail command on my system complains:
>
> 	tail: cannot open `8192' for reading: No such file or directory
>
> if there is any whitespace between the '-c' option and the byte count.
>
> Signed-off-by: A Large Angry SCM <Gitzilla@gmail.com>
> ---
>
>  t/t5302-pack-index.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh
> index 232e5f1..b7870a8 100755
> --- a/t/t5302-pack-index.sh
> +++ b/t/t5302-pack-index.sh
> @@ -16,7 +16,7 @@ test_expect_success \
>           test-genrandom "$i" 8192 >>file_$i &&
>           git-update-index --add file_$i || return 1
>       done &&
> -     echo 101 >file_101 && tail -c 8192 file_100 >>file_101 &&
> +     echo 101 >file_101 && tail -c8192 file_100 >>file_101 &&
>       git-update-index --add file_101 &&
>       tree=`git-write-tree` &&
>       commit=`git-commit-tree $tree </dev/null` && {

I do not like using tail to do a byte-oriented thing like this
to begin with.  How about using the plain old trustworthy and
portable program, "dd", instead?

  reply	other threads:[~2007-04-24  0:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-23 23:56 [PATCH] Fix tail option problem in test A Large Angry SCM
2007-04-24  0:09 ` Junio C Hamano [this message]
2007-04-24  0:29   ` A Large Angry SCM
2007-04-24  5:02     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4pn6d459.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=gitzilla@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).