From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] commit-tree: bump MAX_PARENTS to 128
Date: Tue, 27 Feb 2007 03:06:15 -0800 [thread overview]
Message-ID: <7v4pp7hnbs.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070227105212.GA21757@coredump.intra.peff.net> (Jeff King's message of "Tue, 27 Feb 2007 05:52:12 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Feb 27, 2007 at 02:23:02AM -0800, Junio C Hamano wrote:
>
>> Although pointers to component project commits are represented
>> as "parent" field in commit objects, I suspect that you wish
>> they were treated as if they were tree objects contained in the
>> toplevel commits more often than not for the purposes of many
>> git operations.
>
> Yes, that is exactly correct. One problem I realized after doing this is
> that you get unexpected results from "git-whatchanged -- subproject/".
> My first expectation was to see _just_ the history of the subproject.
> But of course, you see only the merge commit, since the previous commits
> for that subproject didn't have that path at all (they were in the
> root!). Subproject support would fix that, as would simply rewriting
> the history.
For the record, I am aware of the fact that the recent git.git
itself exhibits this exact problem, due to the subtree merge of
git-gui repository. I haven't got to the point of being annoyed
enough to regret it, but running "git show" on merges from Shawn
always needs -M option to make heads or tails of.
next prev parent reply other threads:[~2007-02-27 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 12:15 [RFC/PATCH] commit-tree: bump MAX_PARENTS to 128 Jeff King
2007-02-26 14:31 ` Shawn O. Pearce
2007-02-26 16:38 ` Johannes Schindelin
2007-02-27 8:16 ` Junio C Hamano
2007-02-27 8:19 ` Jeff King
2007-02-27 10:23 ` Junio C Hamano
2007-02-27 10:52 ` Jeff King
2007-02-27 11:06 ` Junio C Hamano [this message]
2007-02-27 11:31 ` Andy Parkins
2007-02-27 11:39 ` Jeff King
2007-02-27 14:04 ` Jakub Narebski
2007-02-27 15:46 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pp7hnbs.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).