From: Junio C Hamano <junkio@cox.net>
To: "Art Haas" <ahaas@airmail.net>
Cc: git@vger.kernel.org
Subject: Re: Patch for http-fetch.c and older curl releases
Date: Mon, 18 Sep 2006 16:06:45 -0700 [thread overview]
Message-ID: <7v4pv4pyey.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060918225445.GF1261@artsapartment.org> (Art Haas's message of "Mon, 18 Sep 2006 17:54:45 -0500")
"Art Haas" <ahaas@airmail.net> writes:
> Older curl releases do not define CURLE_HTTP_RETURNED_ERROR, they
> use CURLE_HTTP_NOT_FOUND instead. The trivial patch below fixes
> the build error. Newer curl releases keep the CURLE_HTTP_NOT_FOUND
> definition but using a -DCURL_NO_OLDIES preprocessor flag
> the old name will not be present in the 'curl.h' header. The
> comments in 'curl.h' have more info about the name change.
>
> Signed-off-by: Art Haas <ahaas@airmail.net>
The patch to use older name in a recent program feels going
backwards. The header is only trying to be nice so you can
compile old programs written for older interface that use older
names. If the new way is the primary way with the new interface,
and if we are writing a new program, I think we should write for
the new interface.
Can we have the main code to target the more recent version,
while working around problems with older versions with backward
compatibility macros?
In other words, if the macro HTTP_RETURNED_ERROR is not defined
in the header (i.e. older version), you define it to be the same
as HTTP_NOT_FOUND.
next prev parent reply other threads:[~2006-09-18 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-18 22:54 Patch for http-fetch.c and older curl releases Art Haas
2006-09-18 23:06 ` Junio C Hamano [this message]
2006-09-18 23:57 ` Art Haas
2006-09-19 0:14 ` Junio C Hamano
2006-09-19 0:32 ` Art Haas
2006-09-19 0:37 ` Junio C Hamano
2006-09-19 8:31 ` Johannes Schindelin
2006-09-19 12:20 ` Art Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pv4pyey.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=ahaas@airmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).