From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: [PATCH] show-branch: make --topo-order noop and default.
Date: Wed, 11 Jan 2006 16:05:54 -0800 [thread overview]
Message-ID: <7v4q4ajonx.fsf@assigned-by-dhcp.cox.net> (raw)
It really does not make sense not doing --topo-order.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
* Currently in "pu".
show-branch.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
d899f2bfc64b44e776a87f9c8fdd6abfe819690b
diff --git a/show-branch.c b/show-branch.c
index 9f7e188..f296a87 100644
--- a/show-branch.c
+++ b/show-branch.c
@@ -544,7 +544,6 @@ int main(int ac, char **av)
int no_name = 0;
int sha1_name = 0;
int shown_merge_point = 0;
- int topo_order = 0;
int no_current_branch = 0;
git_config(git_show_branch_config);
@@ -585,7 +584,8 @@ int main(int ac, char **av)
else if (!strcmp(arg, "--independent"))
independent = 1;
else if (!strcmp(arg, "--topo-order"))
- topo_order = 1;
+ /* noop */
+ ;
else
usage(show_branch_usage);
ac--; av++;
@@ -707,8 +707,7 @@ int main(int ac, char **av)
exit(0);
/* Sort topologically */
- if (topo_order)
- sort_in_topological_order(&seen);
+ sort_in_topological_order(&seen);
/* Give names to commits */
if (!sha1_name && !no_name)
--
1.1.1-g8ecb
next reply other threads:[~2006-01-12 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 0:05 Junio C Hamano [this message]
2006-01-13 2:24 ` [PATCH] show-branch: make --topo-order noop and default A Large Angry SCM
2006-01-13 4:11 ` Junio C Hamano
2006-01-13 5:28 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4q4ajonx.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).