From: Junio C Hamano <gitster@pobox.com>
To: "Carlos Martín Nieto" <cmn@elego.de>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: Possible regression in ref advertisement
Date: Tue, 26 Feb 2013 07:46:37 -0800 [thread overview]
Message-ID: <7v621fnkma.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1361891069.9005.11.camel@flaca.cmartin.tk> ("Carlos Martín Nieto"'s message of "Tue, 26 Feb 2013 16:04:29 +0100")
Carlos Martín Nieto <cmn@elego.de> writes:
> Since the libgit2 parser seems to work with it, it's perfectly possible
> I did mess about with the file and then promptly forgot. An error would
> definitely not help here, but I do think a warning should be issued if
> the file isn't quite as it should be. It seems the parser can already
> detect this, so it could be as easy as adding a fprintf(stderr, "...").
Yeah, another thing that may be worth checking is if this was
written/corrupted by hand, in which case there is no need to worry
about it further, or by something else, e.g. reimplementations such
as jgit and libgit2, or a third-party tool that wants to be
compatible with Git, in which case we do want to see that get fixed.
prev parent reply other threads:[~2013-02-26 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 16:58 Possible regression in ref advertisement Carlos Martín Nieto
2013-02-25 18:31 ` Junio C Hamano
2013-02-25 19:18 ` Carlos Martín Nieto
2013-02-25 19:27 ` Junio C Hamano
2013-02-25 19:54 ` Carlos Martín Nieto
2013-02-25 20:07 ` Junio C Hamano
2013-02-25 20:35 ` Carlos Martín Nieto
2013-02-25 21:16 ` Junio C Hamano
2013-02-26 15:04 ` Carlos Martín Nieto
2013-02-26 15:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v621fnkma.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).