From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: in_merge_bases() is too expensive for recent "pu" update
Date: Fri, 24 Aug 2012 08:50:55 -0700 [thread overview]
Message-ID: <7v62882srk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87sjbceiu9.fsf@thomas.inf.ethz.ch> (Thomas Rast's message of "Fri, 24 Aug 2012 11:32:14 +0200")
Thomas Rast <trast@student.ethz.ch> writes:
> Well, yeah, you snipped this part from my original post :-)
>
> } Even if this turns out to be flawed, we should also identify uses of
> } in_merge_bases() where the real question was is_descendant_of() [I
> } somewhat suspect that's all of them], and then replace is_descendant_of
> } with a much cheaper lookup. This can be as simple as propagating a mark
> } from the candidate until it either goes beyond all possible ancestors,
> } or hits one of them.
Yeah, I agree with the above, and the "cheaper lookup" would
probably be merge-bases-many() without postprocess.
next prev parent reply other threads:[~2012-08-24 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:32 in_merge_bases() is too expensive for recent "pu" update Nguyen Thai Ngoc Duy
2012-08-23 14:20 ` Thomas Rast
2012-08-23 18:08 ` Junio C Hamano
2012-08-23 20:42 ` Junio C Hamano
2012-08-23 21:03 ` Junio C Hamano
2012-08-24 9:32 ` Thomas Rast
2012-08-24 15:50 ` Junio C Hamano [this message]
2012-08-24 9:43 ` Thomas Rast
2012-08-24 15:15 ` Jeff King
2012-08-24 16:15 ` Junio C Hamano
2012-08-24 15:52 ` Junio C Hamano
2012-08-24 11:42 ` Nguyen Thai Ngoc Duy
2012-08-24 11:51 ` Nguyen Thai Ngoc Duy
2012-08-28 1:50 ` Junio C Hamano
2012-08-28 8:12 ` Thomas Rast
2012-08-28 16:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62882srk.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).