git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð" <avarab@gmail.com>,
	"Jiang Xin" <worldhello.net@gmail.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote
Date: Tue, 21 Aug 2012 15:05:46 -0700	[thread overview]
Message-ID: <7v628bdhol.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1345523464-14586-7-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Tue, 21 Aug 2012 11:31:03 +0700")

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> From: Jiang Xin <worldhello.net@gmail.com>
>
> Use i18n-specific test functions in test scripts for git-remote.
> This issue was was introduced in v1.7.10-233-gbb16d5:
>
>     bb16d5 i18n: remote: mark strings for translation
>
> and been broken under GETTEXT_POISON=YesPlease since.
>
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  t/t5505-remote.sh | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
> index e8af615..07045e3 100755
> --- a/t/t5505-remote.sh
> +++ b/t/t5505-remote.sh
> @@ -27,10 +27,16 @@ tokens_match () {
>  	test_cmp expect actual
>  }
>  
> +tokens_i18nmatch () {
> +	echo "$1" | tr ' ' '\012' | sort | sed -e '/^$/d' >expect &&
> +	echo "$2" | tr ' ' '\012' | sort | sed -e '/^$/d' >actual &&
> +	test_i18ncmp expect actual
> +}
> +
>  check_remote_track () {
>  	actual=$(git remote show "$1" | sed -ne 's|^    \(.*\) tracked$|\1|p')
>  	shift &&
> -	tokens_match "$*" "$actual"
> +	tokens_i18nmatch "$*" "$actual"
>  }

Which part of the output from "git remote show" does this test
expect to be translated?  Specifically, does "tracked" ever get
translated?

It appears that _(" tracked") is indeed marked for translation in
the source, so how can we expect value in $actual be any useful for
any comparison?

Confused...

  reply	other threads:[~2012-08-21 22:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21  4:30 [PATCH 0/7] Gettext poison fixes Nguyễn Thái Ngọc Duy
2012-08-21  4:30 ` [PATCH 1/7] Fix tests under GETTEXT_POISON on relative dates Nguyễn Thái Ngọc Duy
2012-08-21  4:30 ` [PATCH 2/7] Fix tests under GETTEXT_POISON on git-stash Nguyễn Thái Ngọc Duy
2012-08-21  4:31 ` [PATCH 3/7] Fix tests under GETTEXT_POISON on diffstat Nguyễn Thái Ngọc Duy
2012-08-21  4:31 ` [PATCH 4/7] Fix tests under GETTEXT_POISON on git-apply Nguyễn Thái Ngọc Duy
2012-08-21  4:31 ` [PATCH 5/7] Fix tests under GETTEXT_POISON on pack-object Nguyễn Thái Ngọc Duy
2012-08-21  5:17   ` Jonathan Nieder
2012-08-21 10:39     ` Nguyen Thai Ngoc Duy
2012-08-21 14:24       ` Jonathan Nieder
2012-08-21 17:53         ` Junio C Hamano
2012-08-21  4:31 ` [PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote Nguyễn Thái Ngọc Duy
2012-08-21 22:05   ` Junio C Hamano [this message]
2012-08-22 14:56     ` Jiang Xin
2012-08-22 19:39       ` Junio C Hamano
2012-08-21  4:31 ` [PATCH 7/7] Fix tests under GETTEXT_POISON on parseopt Nguyễn Thái Ngọc Duy
2012-08-27  5:36 ` [PATCH v2 0/7] Gettext poison fixes Jiang Xin
2012-08-27  5:36 ` [PATCH v2 1/7] Fix tests under GETTEXT_POISON on relative dates Jiang Xin
2012-08-27 16:18   ` Junio C Hamano
2012-08-27  5:36 ` [PATCH v2 2/7] Fix tests under GETTEXT_POISON on git-stash Jiang Xin
2012-08-27  5:36 ` [PATCH v2 3/7] Fix tests under GETTEXT_POISON on diffstat Jiang Xin
2012-08-27  5:36 ` [PATCH v2 4/7] Fix tests under GETTEXT_POISON on git-apply Jiang Xin
2012-08-27  5:36 ` [PATCH v2 5/7] Fix tests under GETTEXT_POISON on pack-object Jiang Xin
2012-08-27  5:36 ` [PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote Jiang Xin
2012-08-27 16:28   ` Junio C Hamano
2012-08-27 21:25     ` Jiang Xin
2012-08-28  1:27       ` Junio C Hamano
2012-08-27  5:36 ` [PATCH v2 7/7] Fix tests under GETTEXT_POISON on parseopt Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v628bdhol.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).