From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Sebastian Pipping <sebastian@pipping.org>
Subject: Re: [PATCH (bugfix)] gitweb: Fix unintended "--no-merges" for regular Atom feed
Date: Wed, 04 Apr 2012 10:47:38 -0700 [thread overview]
Message-ID: <7v62df9yo5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1333542344-20421-1-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Wed, 4 Apr 2012 14:25:44 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Junio, the bug is very minor, so I don't know if it is worth fixing
> for 1.7.10.
Does this exist in 1.7.9.x maintenance track? If it is an old bug, I do
not think it should go to 1.7.10 proper (perhaps 1.7.10.1) this late, and
if it is a bug in a new feature added for 1.7.10, we may want to fix it
before the final, as the impact of the patch seems very minor.
> gitweb/gitweb.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a8b5fad2..ca6f038 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3886,6 +3886,7 @@ sub print_feed_meta {
> '-type' => "application/$type+xml"
> );
>
> + $href_params{'extra_options'} = undef;
> $href_params{'action'} = $type;
> $link_attr{'-href'} = href(%href_params);
> print "<link ".
next prev parent reply other threads:[~2012-04-04 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:44 [PATCH] Gitweb: Fix unintended "--no-merges" for regular Atom feed Sebastian Pipping
2012-04-04 12:25 ` [PATCH (bugfix)] gitweb: " Jakub Narebski
2012-04-04 17:47 ` Junio C Hamano [this message]
2012-04-04 18:58 ` Jakub Narebski
2012-04-11 15:39 ` Jakub Narebski
2012-04-11 16:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62df9yo5.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=sebastian@pipping.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).