From: Junio C Hamano <gitster@pobox.com>
To: Vincent van Ravesteijn <vfr@lyx.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix a warning about conversion to float
Date: Tue, 06 Mar 2012 10:58:22 -0800 [thread overview]
Message-ID: <7v62ehtv3l.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1331024077-5736-1-git-send-email-user@vincent-VirtualBox> (Vincent van Ravesteijn's message of "Tue, 6 Mar 2012 09:54:36 +0100")
Vincent van Ravesteijn <vfr@lyx.org> writes:
> From: Vincent van Ravesteijn <vfr@lyx.org>
>
> Below in the same function, val is correctly casted to a float. Do this also
> for the initialization of x.
Hrm, is it correctly casted or needlessly casted?
It is unclear what problem you are trying to solve here.
> @@ -550,6 +550,7 @@ static int sqrti(int val)
> return (int)x;
> }
>
> +
> static struct commit_list *skip_away(struct commit_list *list, int count)
Huh?
prev parent reply other threads:[~2012-03-06 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 8:54 [PATCH 1/2] Fix a warning about conversion to float Vincent van Ravesteijn
2012-03-06 8:54 ` [PATCH 2/2] Disambiguate PREFIX define in sideband.c Vincent van Ravesteijn
2012-03-06 19:04 ` Junio C Hamano
2012-03-06 18:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62ehtv3l.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vfr@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).