From: Junio C Hamano <gitster@pobox.com>
To: "Frans Klaver" <fransklaver@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] run-command.c: Accept EACCES as command not found
Date: Mon, 21 Nov 2011 15:54:09 -0800 [thread overview]
Message-ID: <7v62idf2vy.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <op.v5bjtk1r0aolir@keputer> (Frans Klaver's message of "Tue, 22 Nov 2011 00:06:46 +0100")
"Frans Klaver" <fransklaver@gmail.com> writes:
> Actually I went through diagnosing and fixing it. After tracking it
> down, I did wonder about this question myself and I didn't come to a
> definitive conclusion on it. On one hand I do agree that it may be an
> incentive for the user to fix his path. On the other hand I found it
> an obscure one to track down; git's behavior doesn't match bash
> behavior:
>
> $ git config --global alias.aliasedinit init &&
> mkdir searchpath && chmod 400 searchpath &&
> PATH=$(pwd)/searchpath:$PATH && export PATH &&
> mkdir someproject && cd someproject &&
> git aliasedinit
> fatal: cannot exec 'git-aliasedinit': Permission denied
Imagine you did not have alias.aliasedinit in ~/.gitconfig but had a
script called $(pwd)/searchpath/git-aliasedinit which we would fail to
execute. What message would we get in that case? Currently I think we get
permission denied.
Would we get the same with your patch, or something that does not hint
at all that there is a permission problem?
See also the "tangent" part of
http://thread.gmane.org/gmane.comp.version-control.git/171755
and the discussion that follows it. I do not think we reached any
conclusion nor a patch.
next prev parent reply other threads:[~2011-11-21 23:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 21:53 [PATCH] run-command.c: Accept EACCES as command not found Frans Klaver
2011-11-21 22:13 ` Junio C Hamano
2011-11-21 23:06 ` Frans Klaver
2011-11-21 23:54 ` Junio C Hamano [this message]
2011-11-22 9:31 ` Frans Klaver
2011-11-23 8:17 ` Frans Klaver
2011-11-23 12:04 ` Nguyen Thai Ngoc Duy
2011-11-23 13:25 ` Frans Klaver
2011-11-23 22:55 ` Frans Klaver
2011-12-06 21:38 ` [PATCH 0/2] run-command: Add EACCES diagnostics Frans Klaver
2011-12-06 21:38 ` [PATCH 1/2] run-command: Add checks after execvp fails with EACCES Frans Klaver
2011-12-06 22:35 ` Junio C Hamano
2011-12-07 8:31 ` Frans Klaver
2011-12-08 21:44 ` Frans Klaver
2011-12-09 17:23 ` Junio C Hamano
2011-12-09 21:35 ` Frans Klaver
2011-12-06 21:38 ` [PATCH 2/2] run-command: Add interpreter permissions check Frans Klaver
2011-12-06 22:47 ` Junio C Hamano
2011-12-07 8:37 ` Frans Klaver
2011-12-13 15:08 ` [PATCH 0/2 v2] run-command: Add eacces diagnostics Frans Klaver
2011-12-13 15:08 ` [PATCH 1/2] run-command: Add checks after execvp fails with EACCES Frans Klaver
2011-12-13 19:01 ` Junio C Hamano
2011-12-14 14:31 ` Frans Klaver
2011-12-14 22:06 ` Frans Klaver
2011-12-13 15:08 ` [PATCH 2/2] run-command: Add interpreter permissions check Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62idf2vy.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).