From: Junio C Hamano <gitster@pobox.com>
To: Thomas Hochstein <thh@inter.net>
Cc: git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] documentation fix: git difftool uses diff tools, not merge tools.
Date: Mon, 14 Nov 2011 16:20:56 -0800 [thread overview]
Message-ID: <7v62imi6c7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1321311352-8950-1-git-send-email-thh@inter.net> (Thomas Hochstein's message of "Mon, 14 Nov 2011 23:55:52 +0100")
Thomas Hochstein <thh@inter.net> writes:
> Let the documentation for -t list valid *diff* tools,
> not valid *merge* tools.
>
> Signed-off-by: Thomas Hochstein <thh@inter.net>
> ---
> Documentation/git-difftool.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/git-difftool.txt b/Documentation/git-difftool.txt
> index a03515f..19d473c 100644
> --- a/Documentation/git-difftool.txt
> +++ b/Documentation/git-difftool.txt
> @@ -31,7 +31,7 @@ OPTIONS
> -t <tool>::
> --tool=<tool>::
> Use the diff tool specified by <tool>.
> - Valid merge tools are:
> + Valid diff tools are:
> araxis, bc3, diffuse, emerge, ecmerge, gvimdiff, kdiff3,
> kompare, meld, opendiff, p4merge, tkdiff, vimdiff and xxdiff.
> +
The patch is obviously correct, and it is so trivial that there is no risk
of breaking anything. It would even be OK for 1.7.7.X maintenance series.
But in the longer term, I suspect that we would want to drop this
enumeration from the documentation, and instead give "--list-tools"
option or something to the command. That way, we only need to keep
the list of known tools in one place where it matters, namely, the
command that knows about them.
David, what do you think?
The same comment applies to "git mergetool", I would think.
next prev parent reply other threads:[~2011-11-15 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 22:55 [PATCH] documentation fix: git difftool uses diff tools, not merge tools Thomas Hochstein
2011-11-15 0:20 ` Junio C Hamano [this message]
2011-11-21 12:25 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62imi6c7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=thh@inter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox