From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 1/5] test-lib: Adjust output to be valid TAP format
Date: Fri, 25 Jun 2010 14:36:07 -0700 [thread overview]
Message-ID: <7v6316kd6g.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTilYoGtTIr9lIQD4sx4PRjlWYjIwSDMquREzv6eq@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri\, 25 Jun 2010 21\:24\:47 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Fri, Jun 25, 2010 at 17:21, Junio C Hamano <gitster@pobox.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> diff --git a/t/README b/t/README
>>> index 0e4e8d8..aa4ed28 100644
>>> --- a/t/README
>>> +++ b/t/README
>>> @@ -18,25 +18,48 @@ The easiest way to run tests is to say "make". This runs all
>>> ...
>>
>> This describes the general framework of tests from the point of view of a
>> person who runs them and reads their output well. I'll replace ab/tap
>> topic with these five patches.
>> ...
>> I'd however like to ask you to update the sections in t/README to help
>> test writers....
>>
>> Earlier I kept wondering if this series is worth the trouble. Having to
>> learn and follow the set of these new rules is exactly what I meant by
>> "trouble". Let's make sure that the new rules are clear, small, and easy
>> to follow for other contributors.
>
> I'll write those docs, but I probably won't have time in the next few
> days so I'll submit a patch for that it separately if that's OK.
Oh, absolutely. I meant to say that v4/v5 round already has a good
documentation for test users/readers; a follow-up patch to help test
writers would make the series more complete.
Thanks.
next prev parent reply other threads:[~2010-06-25 21:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 17:44 [PATCH v4 0/5] TAP support for Git Ævar Arnfjörð Bjarmason
2010-06-24 17:44 ` [PATCH v4 1/5] test-lib: Adjust output to be valid TAP format Ævar Arnfjörð Bjarmason
2010-06-24 18:39 ` Jakub Narebski
2010-06-24 19:17 ` Ævar Arnfjörð Bjarmason
2010-06-24 21:52 ` [PATCH v5 " Ævar Arnfjörð Bjarmason
2010-06-25 17:21 ` Junio C Hamano
2010-06-25 21:24 ` Ævar Arnfjörð Bjarmason
2010-06-25 21:36 ` Junio C Hamano [this message]
2010-06-25 21:39 ` Ævar Arnfjörð Bjarmason
2010-06-24 17:44 ` [PATCH v4 2/5] test-lib: Make the test_external_* functions TAP-aware Ævar Arnfjörð Bjarmason
2010-06-24 17:44 ` [PATCH v4 3/5] test-lib: output a newline before "ok" under a TAP harness Ævar Arnfjörð Bjarmason
2010-06-24 17:44 ` [PATCH v4 4/5] tests: Skip tests in a way that makes sense under TAP Ævar Arnfjörð Bjarmason
2010-06-24 17:44 ` [PATCH v4 5/5] tests: Say "pass" rather than "ok" on empty lines for TAP Ævar Arnfjörð Bjarmason
2010-06-26 12:21 ` [PATCH] t9700: Use Test::More->builder, not $Test::Builder::Test Ævar Arnfjörð Bjarmason
2010-06-26 12:42 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-06-27 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v6316kd6g.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).