From: Junio C Hamano <gitster@pobox.com>
To: Greg Bacon <gbacon@dbresearch.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: git-add: correct first example
Date: Mon, 08 Feb 2010 12:08:17 -0800 [thread overview]
Message-ID: <7v6367lccu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vsk9bmt1h.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 08 Feb 2010 11\:22\:34 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> and its subdirectories:
>> +
>> ------------
>> -$ git add Documentation/\\*.txt
>
> This indeed results in double-backslash in the output.
>
>> +$ git add Documentation/\*.txt
>
> and this seems to fix it.
>
> Thanks.
To look for similar breakages, I ran
git grep -n -e '\\\\' -- 'Documentation/*.txt'
and found this in git-rm.txt:
EXAMPLES
--------
git rm Documentation/\\*.txt::
Removes all `\*.txt` files from the index that are under the
`Documentation` directory and any of its subdirectories.
What is intereseting is that this is rendered correctly. Quoting rule in
AsciiDoc is mysterious...
It turns out that the breakage in "git add" documentation was a
regression; the examples were written in a similar way to the one in "git
rm" documentation. When 921177f (Documentation: improve "add", "pull" and
"format-patch" examples, 2008-05-07) converted it to displayed text,
nobody noticed that the difference in the backslash quoting rule between
the enumeration header and displayed text.
prev parent reply other threads:[~2010-02-08 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 17:35 [PATCH] Documentation: git-add: correct first example Greg Bacon
2010-02-08 19:22 ` Junio C Hamano
2010-02-08 20:08 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v6367lccu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=gbacon@dbresearch.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).