git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH] fix portability issues with $ in double quotes
Date: Wed, 27 Jan 2010 11:16:00 -0800	[thread overview]
Message-ID: <7v636nqryn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4B608A3C.7090106@gmail.com> (Stephen Boyd's message of "Wed\, 27 Jan 2010 10\:47\:24 -0800")

Stephen Boyd <bebarino@gmail.com> writes:

> On 01/26/2010 11:53 PM, Johannes Sixt wrote:
>> The instances you changed look good. I didn't check whether you missed
>> some. Was this some sort of mechanical change?
>
> Not really mechanical. I just grepped for sed and grep expressions and
> then went through the results by hand looking for unescaped dollar
> signs.

Thanks; with this (and my earlier rant on bash refusing to redirect with
'cmd <$variable' when $variable has $IFS character and is not quoted), the
result seem to make my OpenBSD build pass all the tests ;-)

      reply	other threads:[~2010-01-27 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 23:08 [PATCH] fix portability issues with $ in double quotes Stephen Boyd
2010-01-27  7:53 ` Johannes Sixt
2010-01-27 18:47   ` Stephen Boyd
2010-01-27 19:16     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v636nqryn.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).