Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Mike Galbraith <efault@gmx.de>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jon Jensen <jon@endpoint.com>,
	git@vger.kernel.org
Subject: Re: How to stop sharing objects between repositories
Date: Mon, 17 Aug 2009 00:24:22 -0700	[thread overview]
Message-ID: <7v63cm3ntl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090817064801.GA31543@coredump.intra.peff.net> (Jeff King's message of "Mon\, 17 Aug 2009 02\:48\:02 -0400")

Jeff King <peff@peff.net> writes:

> On Mon, Aug 17, 2009 at 04:21:22AM +0200, Mike Galbraith wrote:
>
>> >  (1) Such a user does not necessarily know a casual "git repack -a" breaks
>> >      the dependency, defeating the -s option s/he deliberately used in
>> >      order to save disk space in the first place.  Perhaps we can reword
>> >      this further to kill two penguins with a single stone?
>> 
>> Perhaps a runtime warning that you're about to break it?  This user may
>> not even be the one who set the thing up, no?
>
> I'm not really sure what such a setup would look like....
> ...
> That being said, I can see there being setups where such a warning might
> be useful. However, we don't really know if the user _wants_ that
> effect, or if it is an accident.
> ...
> "here is how you break the dependency" advice will also get the warning.
>
> I'm torn on whether this is actually a good idea.

I would understand if you were torn if the proposed change were to refuse
to run without -l in a repository with alternates when --force is not
given, or something of that nature.

But I can tell you that this "just warn" cannot be a good idea for a very
simple reason: breaking and then warning is useless---it is too late for
the user to do anything about it.

  parent reply	other threads:[~2009-08-17  7:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16  0:04 How to stop sharing objects between repositories Jon Jensen
2009-08-16  8:43 ` Johannes Schindelin
2009-08-16 12:28   ` Jeff King
2009-08-16 12:30     ` Johannes Schindelin
2009-08-16 13:54       ` Daniel Villeneuve
2009-08-16 13:57         ` Johannes Schindelin
2009-08-16 13:57       ` Jeff King
2009-08-16 19:16         ` Junio C Hamano
2009-08-17  2:21           ` Mike Galbraith
2009-08-17  6:48             ` Jeff King
2009-08-17  7:12               ` Mike Galbraith
2009-08-17  7:24               ` Junio C Hamano [this message]
2009-08-17  7:25                 ` Jeff King
2009-08-17  7:35                   ` Junio C Hamano
2009-08-17  7:50                     ` Jeff King
2009-08-17  6:19           ` Jeff King
2009-08-17  6:32             ` Jeff King
2009-08-17  6:31           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v63cm3ntl.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=efault@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jon@endpoint.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox