From: Junio C Hamano <gitster@pobox.com>
To: Joe Perches <joe@perches.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] builtin-log: Add options to --coverletter
Date: Fri, 15 May 2009 19:30:29 -0700 [thread overview]
Message-ID: <7v63g1srsq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1242425263.31337.17.camel@Joe-Laptop.home> (Joe Perches's message of "Fri\, 15 May 2009 15\:07\:43 -0700")
Joe Perches <joe@perches.com> writes:
>> > +static int coverletter_wrap = 1;
>>
>> Do not change the default behaviour before people agree it is a good
>> feature;
>
> This doesn't change the default behavior.
> The default is still wrap enabled.
You are correct; my mistake.
> Prefixing "no-" to git arguments seems widely used.
>
> Perhaps:
> --no-cover-letter-wrap
Again you are right; it looks much better.
next prev parent reply other threads:[~2009-05-16 2:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 0:57 [RFC PATCH] builtin-log: Add options to --coverletter Joe Perches
2009-05-15 18:11 ` Junio C Hamano
2009-05-15 20:19 ` Joe Perches
2009-05-15 21:51 ` Junio C Hamano
2009-05-15 22:07 ` Joe Perches
2009-05-16 2:30 ` Junio C Hamano [this message]
2009-05-16 0:46 ` Joe Perches
2009-05-16 2:32 ` Junio C Hamano
2009-05-16 5:07 ` Jeff King
2009-05-16 17:35 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63g1srsq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).