From: Junio C Hamano <gitster@pobox.com>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: Eric Wong <normalperson@yhbt.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Fix sloppy Getopt::Long.
Date: Wed, 06 May 2009 10:24:50 -0700 [thread overview]
Message-ID: <7v63gew3dp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090506161309.GC10702@curie-int> (Robin H. Johnson's message of "Wed\, 6 May 2009 09\:13\:09 -0700")
"Robin H. Johnson" <robbat2@gentoo.org> writes:
> On Tue, May 05, 2009 at 11:49:49PM -0700, Eric Wong wrote:
>> Junio C Hamano <gitster@pobox.com> wrote:
>> > "Robin H. Johnson" <robbat2@gentoo.org> writes:
>> >
>> > > Getopt-Long v2.38 is much stricter about sloppy getopt usage. The
>> > > trailing pipe causes git-svn testcases to fail for all of the --stdin
>> > > argument calls.
>> > >
>> > > Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
>> >
>> > Eric, I'll take this directly to my tree. Ok?
>>
>> The empty "" after the "|" was intended for the set-tree command to take
>> a lone "-" as a parameter to also mean "--stdin".
>>
>> The following should work, too, but I don't have time to test right now:
>>
>> + { '' => \$_stdin, 'stdin' => \$_stdin,
>> + %cmt_opts, %fc_opts, } ],
> I confirm that it does correctly set the $_stdin variable (tested
> briefly).
Wait a minute. Do you mean we would also need the above "explicit empty
argument sets $_stdin"? Wasn't it your earlier analysis/claim that the
caller already takes care of a lone "-"?
Or do you mean "yes it would also work but it is not necessary"?
next prev parent reply other threads:[~2009-05-06 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 18:16 [PATCH] Fix sloppy Getopt::Long Robin H. Johnson
2009-05-05 19:37 ` Junio C Hamano
2009-05-05 20:21 ` Robin H. Johnson
[not found] ` <7vljpazuyg.fsf@alter.siamese.dyndns.org>
[not found] ` <20090506064949.GB29479@dcvr.yhbt.net>
2009-05-06 16:13 ` Robin H. Johnson
2009-05-06 17:24 ` Junio C Hamano [this message]
2009-05-08 18:28 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63gew3dp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).