From: Junio C Hamano <gitster@pobox.com>
To: "Kirill A. Korinskiy" <catap@catap.ru>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http-push: support full URI in handle_remote_ls_ctx()
Date: Sun, 18 Jan 2009 13:28:04 -0800 [thread overview]
Message-ID: <7v63kcuwwr.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1232278116-6631-1-git-send-email-catap@catap.ru
"Kirill A. Korinskiy" <catap@catap.ru> writes:
> @@ -1424,9 +1425,18 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
> ls->userFunc(ls);
> }
> } else if (!strcmp(ctx->name, DAV_PROPFIND_NAME) && ctx->cdata) {
> - ls->dentry_name = xmalloc(strlen(ctx->cdata) -
> + char *path = ctx->cdata;
> + if (!strcmp(ctx->cdata, "http://")) {
> + path = strchr(path + sizeof("http://") - 1, '/');
> + } else if (!strcmp(ctx->cdata, "https://")) {
> + path = strchr(path + sizeof("https://") - 1, '/');
> + }
> +
> + path += remote->path_len;
I see you chose to address the issue I pointed out in:
http://thread.gmane.org/gmane.comp.version-control.git/103804/focus=104363
by being more strict. That's the only change I can spot compared to
e1f33ef (http-push: support full URI in handle_remote_ls_ctx(),
2008-12-23) that is already in maint.
Could you make this into an incremental patch?
next prev parent reply other threads:[~2009-01-18 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 11:28 [PATCH] http-push: support full URI in handle_remote_ls_ctx() Kirill A. Korinskiy
2009-01-18 14:51 ` Johannes Schindelin
2009-01-18 21:28 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-25 7:04 [PATCH] handle_remote_ls_ctx can parsing href starting at http:// Junio C Hamano
2008-12-29 2:32 ` [PATCH] http-push: support full URI in handle_remote_ls_ctx() Kirill A. Korinskiy
2008-12-29 7:17 ` Mike Hommey
2008-12-29 8:36 ` Junio C Hamano
2009-01-02 6:53 ` Kirill A. Korinskiy
2009-01-02 7:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63kcuwwr.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=catap@catap.ru \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).