From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] autodetect number of CPUs by default when using threads
Date: Thu, 11 Dec 2008 14:25:08 -0800 [thread overview]
Message-ID: <7v63lqcptn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0812111524370.14328@xanadu.home> (Nicolas Pitre's message of "Thu, 11 Dec 2008 15:36:47 -0500 (EST)")
Nicolas Pitre <nico@cam.org> writes:
> I've spent quite a while wondering why repacking in one repo was faster
> than repacking in a clone of that repo on the same machine. So let's
> display how many threads are actually used.
>
> We have comprehensive test in Makefile to determine if threads are
> available, just to not use them by default. I think that code has
> proven itself for long enough now not to let people benefit from it.
Hmm, it does appear that distros compile with THREADED_DELTA_SEARCH turned
on (I only checked Fedora and Debian), and I tend to agree with "long
enough" but "proven itself" feels bit too strong a statement.
I think defaulting to autodetect is a good change. I do not like to add
new output to stderr deep in -rc, though.
Can we park this in 'next' and move it to 'master' after 1.6.1?
next prev parent reply other threads:[~2008-12-11 22:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 20:36 [PATCH] autodetect number of CPUs by default when using threads Nicolas Pitre
2008-12-11 22:25 ` Junio C Hamano [this message]
2008-12-12 0:55 ` Nicolas Pitre
2008-12-13 13:32 ` Jeff King
2008-12-13 19:27 ` Nicolas Pitre
2008-12-13 20:06 ` [PATCH] pack-objects: don't use too many threads with few objects Nicolas Pitre
2008-12-14 2:20 ` Jeff King
2008-12-15 18:38 ` Mike Ralphson
2008-12-16 1:15 ` Junio C Hamano
2008-12-16 3:20 ` Jeff King
2008-12-16 5:21 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63lqcptn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).