git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Raible <raible@gmail.com>
Cc: git@vger.kernel.org, Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Subject: Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial
Date: Mon, 25 Aug 2008 14:53:48 -0700	[thread overview]
Message-ID: <7v63pog3rn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20080825T200956-169@post.gmane.org> (Eric Raible's message of "Mon, 25 Aug 2008 20:12:03 +0000 (UTC)")

Eric Raible <raible@gmail.com> writes:

> Paolo Ciarrocchi <paolo.ciarrocchi <at> gmail.com> writes:
>
>> +Alice can also use gitk to browse that Bob did:
>
> s/that/what/ ?
>
>> +------------------------------------------------
>> +alice$ gitk master origin/master
>> +------------------------------------------------
>
> I think that you meant:
>
> alice$ gitk master..origin/master


I'd suggest rewording the explanation to have Alice "compare what both of
them did", not just "browse what Bob did".

And for that purpose, I think the original form used by Paolo's patch is
the most appropriate here in an early part of the tutorial, as it teaches
how to view full histories leading to the tips of these two branches.

Earlier in the tutorial sequence we teach "gitk" without any parameter to
view the history of the current branch, and here the user learns one new
thing, to view more than just the current branch.

Limiting the output with "..origin/master" (or "...origin/master") can be
taught after demonstrating this most basic form.

  parent reply	other threads:[~2008-08-25 21:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25 19:50 [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial Paolo Ciarrocchi
2008-08-25 20:12 ` Eric Raible
2008-08-25 20:33   ` Paolo Ciarrocchi
2008-08-25 21:53   ` Junio C Hamano [this message]
2008-08-25 22:12     ` Paolo Ciarrocchi
2008-08-26  0:29       ` Junio C Hamano
2008-08-26  8:16         ` Paolo Ciarrocchi
2008-08-26  8:24           ` Eric Raible
2008-08-26  8:45             ` Paolo Ciarrocchi
2008-08-26  9:44               ` Paolo Ciarrocchi
2008-08-26 18:13           ` Junio C Hamano
2008-08-27  7:58             ` Paolo Ciarrocchi
     [not found]               ` <402731c90808270121t5c09efd1m3b60a1ad15f8f705@mail.gmail.com>
2008-08-27  8:26                 ` Paolo Ciarrocchi
2008-08-27 18:06               ` Junio C Hamano
2008-08-28 13:03                 ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v63pog3rn.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    --cc=raible@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).